Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take(n) now behaves as take(n,true)/limitRequest #2969

Merged
merged 8 commits into from
Mar 17, 2022
Merged

Take(n) now behaves as take(n,true)/limitRequest #2969

merged 8 commits into from
Mar 17, 2022

Conversation

simonbasle
Copy link
Contributor

  • step1: Replace take(l) with take(l, false)
  • step 2: replace limitRequest(l) with take(l)
  • step 3: take(long) is now alias for take(long, true)
  • step 4: rework the take(long) javadoc
  • step 5: rework marble diagrams, remove take.svg
  • step 6: Update reference guide (+choice matrix)

Fixes #2690.

@simonbasle simonbasle requested a review from a team as a code owner March 16, 2022 16:35
@simonbasle simonbasle added this to the 3.5.0-M1 milestone Mar 16, 2022
@simonbasle simonbasle added the warn/behavior-change Breaking change of publicly advertised behavior label Mar 16, 2022
@simonbasle simonbasle self-assigned this Mar 16, 2022
@simonbasle simonbasle requested a review from a team March 16, 2022 16:35
@simonbasle simonbasle added the type/enhancement A general enhancement label Mar 16, 2022
@simonbasle
Copy link
Contributor Author

polished the javadoc, which should also trigger the ci workflow after yesterday's GHA outage

pderop
pderop approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonbasle simonbasle merged commit 96bb61f into main Mar 17, 2022
@simonbasle simonbasle deleted the 2690-takeBehavesLikeLimitRequest branch March 17, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violetagg violetagg violetagg approved these changes

@pderop pderop pderop approved these changes

Assignees

@simonbasle simonbasle

Labels
type/enhancement A general enhancement warn/behavior-change Breaking change of publicly advertised behavior
Projects
None yet
Milestone
3.5.0-M1
Development

Successfully merging this pull request may close these issues.

Change behavior of Flux.take to be that of limitRequest
3 participants
@simonbasle @pderop @violetagg