-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish copyright headers and other org changes #2722
Conversation
how the copyright replacement was done:
this was the first commit ☝️ second commit was to harmonize license header URL via a search-and-replace on all files with regexp third commit was to find duplicate copyright headers via terminal: for file in ./**/*; do if [ "$(grep -s -c "Copyright" "${file}")" -gt 1 ]; then echo "${file}"; fi; done then the fourth commit was made to replace all the start dates with the same date (project inception, 2011):
|
The Apache2 license link is also harmonized to be preceded by 2 spaces (+1 space if the rest of the text is preceded by a space as part of the comment marker).
This is the project inception year, not the file creation year.
f17410b
to
3131679
Compare
The Pivotal copyright has been changed to VMware. The date range has been modified across the board to end at 2021. For now start dates have been kept as is.
We keep 3 spaces: one for the comment block marker, 2 for indentation (as in the ASF example).
This is the project inception year, not the file creation year.
3131679
to
b8e0d3b
Compare
Some files had license header twice.
This is the project inception year, not the file creation year.
b8e0d3b
to
66f5817
Compare
This only applies to .java files changed compared to the origin base branch (3.3.x): - Ensure tab indentation is used, with regexp fix for comment blocks - Trim trailing whitespaces - Ensure files end with a blank line - Remove unused imports - Enfore license header with up-to-date end year
This only applies to .java files changed compared to the origin base branch (3.3.x): - Ensure tab indentation is used, with regexp fix for comment blocks - Trim trailing whitespaces - Ensure files end with a blank line - Remove unused imports - Enfore license header with up-to-date end year
This only applies to .java files changed compared to the origin base branch (3.3.x): - Ensure tab indentation is used, with regexp fix for comment blocks - Trim trailing whitespaces - Ensure files end with a blank line - Remove unused imports - Enfore license header with up-to-date end year
the first two commits are the largest (hitting 800+ files) and the other commits are smaller. if you have trouble loading the large ones for review, here is the link to see smaller commits only: https://github.com/reactor/reactor-core/pull/2722/files/054f33f6954b88b459dc5f20a4ab47b85bc17b3a..1cd161835f3f7bc9ce27b3cdaa2268c8d89023d3 |
I'll merge this, forward-merge the change to |
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
The Pivotal copyright has been changed to VMware. The date range has been modified across the board to end at 2021. For now start dates have been kept as is.
We keep 3 spaces: one for the comment block marker, 2 for indentation (as in the ASF example).
Some files had license header twice.
This is the project inception year, not the file creation year.
This commit performs the same changes as in #2722, on files that were introduced in the `main` branch (3.4.x) only. Since the scope is far more restricted, the changes are done in a single commit. See reactor/reactor#682
This only applies to .java files changed compared to the origin base branch (3.3.x): - Ensure tab indentation is used, with regexp fix for comment blocks - Trim trailing whitespaces - Ensure files end with a blank line - Remove unused imports - Enfore license header with up-to-date end year
This commit performs the same changes as in #2722, on files that were introduced in the `main` branch (3.4.x) only. Since the scope is far more restricted, the changes are done in a single commit. See reactor/reactor#682
This reverts commit 6fa6182. The start year MUST reflect the actual year the _content_ of the file (copyrighted material) has been created.
This PR will introduce several commits updating the codebase to be in line with
past organizational changes, like VMware replacing Pivotal in copyright headers,
polishing of date ranges in same headers, pom org and developer list updates.
see reactor/reactor#682