[chore] Bump AssertJ to 3.19.0, polish tests and isolate tckTest #2706
Conversation
simonbasle
added
the
type/chores
| @@ -251,7 +251,7 @@ public void taggedAppendedFluxTest() { | |||
| .tag("2", "Two"); | |||
|
|
|||
| final Stream<Tuple2<String, String>> scannedTags = Scannable.from(tagged1).tags(); | |||
| assertThat(scannedTags.iterator()) | |||
| assertThat(scannedTags) | |||
There was a problem hiding this comment.
Just wondering why there we use stream without .iterator()).toIterable() but in the above changes we do with
There was a problem hiding this comment.
looks like there's no particular reason not to directly assert the Stream itself since AssertJ now supports all the necessary containsXxx assertions on these, will change.
|
yeah i'll make a second pass on that class see if the stream tests can be
simplified. sometimes, depending on the assert, the compiler
complains/warns about generic types
|
|
NB: forward-merging will reveal more tests to amend |
|
mmh actually it doesn't look like the tck tests are run... looking into it |
reactor-core/build.gradle
Outdated
| } | ||
|
|
||
| tckTest { | ||
| useJUnitPlatform() |
There was a problem hiding this comment.
oops... should be useTestNG() (which would be redundant with line 199 above)
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
Conflicts primarily from tests having switched from generic array creation to list based implementations (which we keep).
This pr bumps AssertJ to the latest version, which contains some breaking
changes and rewording of error messages.
Additionally, since the bump surfaces an issue with testNG, we isolate tests
that need testNG (the TCK test) in their own testSet.