Polish corner cases in FluxLimitRequest, complete fast on cap=0 #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that several corner cases are now covered in the FluxLimitRequest operator: - a negative cap is rejected at assembly time - a zero cap leads to immediate completion of the actual during subscription. the source isn't even subscribed to. - extraneous onNext/onError are detected and dropped Note that for eg. `limitRequest(3)`, if the source emits exactly 3 elements then an `onError`, the `limitRequest` operator will still consider itself `onComplete`d (and will now drop the error). Similarly, `Flux.error(th).limitRequest(0)` will immediately _complete_ and the error won't be dropped in that case (since the error Flux won't be subscribed to). Fixes #2698.
violetagg
reviewed
May 5, 2021
simonbasle
changed the title
simonbasle
changed the title
violetagg
approved these changes
May 6, 2021
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
May 6, 2021
simonbasle
added a commit
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that several corner cases are now covered in the
FluxLimitRequest operator:
subscription. the source isn't even subscribed to.
Note that for eg.
limitRequest(3), if the source emits exactly 3elements then an
onError, thelimitRequestoperator will stillconsider itself
onCompleted (and will now drop the error).Similarly,
Flux.error(th).limitRequest(0)will immediately completeand the error won't be dropped in that case (since the error Flux won't
be subscribed to).
Fixes #2698.