[build] Follow-up to #2088 bump to Gradle 6.3 : 3.3 specifics

[simonbasle]

• build-scan plugin (added in 3.3) has been upgraded but must now be
  applied in settings.gradle
• unbroken-dome.test-sets plugin must be bumped to version 3.0.0 for
  Gradle 6.3 compatibility
• Bump of blockhound to 1.0.3 to avoid reactor.shaded version of
  bytebuddy (which confuses BND)
• Exclude blockhound in core's BDN Export-Package

[bsideup]

I am surprised that we need to duplicate it here o_O OSGI is the gift that keeps on giving 😂

[simonbasle]

it otherwise complains about reactor.shaded which IIRC is linked to the wonky stubs stuff we did for StackWalker-and-al

[bsideup]

1. it only applies to reactor-tools, right?
2. what if we explicitly exclude reactor.shaded.*?

[bsideup]

re StackWalker - not the case, but reactor-tools' shading of ByteBuddy

[simonbasle]

In core's build, with

"Export-Package": "!*internal*,!*blockhound*,reactor.*",

We get

error  : Classes found in the wrong directory: {reactor/shaded/META-INF/versions/9/module-info.class=module-info}

Which we can suppress at bnd level with the instruction:

	"-fixupmessages": '"Classes found in the wrong directory";is:=warning',

But then it is japicmp that complains:

Execution failed for task ':reactor-core:japicmp'.
> A failure occurred while executing Comparing [reactor-core-3.3.5.BUILD-SNAPSHOT.jar] with [reactor-core-3.3.0.RELEASE.jar]
   > Failed to load file from jar 'reactor/shaded/META-INF/versions/9/module-info.class' as class file: invalid constant type: 19 at 4.

UPDATE: This appears to be due to blockhound v1.0.0 having a reactor.shaded version of bytebuddy. v1.0.3 removes the reactor prefix so the above configuration works and doesn't pick up the shaded classes.

[codecov-io]

Codecov Report

Merging #2089 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2089      +/-   ##
============================================
+ Coverage     81.97%   81.99%   +0.02%     
- Complexity     4087     4089       +2     
============================================
  Files           380      380              
  Lines         31277    31273       -4     
  Branches       5798     5798              
============================================
+ Hits          25638    25641       +3     
+ Misses         4068     4062       -6     
+ Partials       1571     1570       -1     

Impacted Files	Coverage Δ	Complexity Δ
...re/src/main/java/reactor/core/publisher/Hooks.java	93.10% <100.00%> (ø)	44.00 <1.00> (+1.00)
...va/reactor/core/publisher/ParallelMergeReduce.java	71.31% <0.00%> (-1.64%)	3.00% <0.00%> (ø%)
...rc/main/java/reactor/core/publisher/FluxRange.java	88.07% <0.00%> (-1.33%)	6.00% <0.00%> (ø%)
...eactor/core/publisher/ParallelMergeSequential.java	84.97% <0.00%> (-0.52%)	7.00% <0.00%> (ø%)
...ain/java/reactor/core/publisher/FluxPublishOn.java	86.77% <0.00%> (-0.21%)	6.00% <0.00%> (ø%)
...rc/main/java/reactor/core/publisher/Operators.java	81.44% <0.00%> (+0.13%)	136.00% <0.00%> (+1.00%)
...c/main/java/reactor/core/publisher/FluxReplay.java	85.09% <0.00%> (+0.14%)	29.00% <0.00%> (ø%)
...ain/java/reactor/core/publisher/FluxConcatMap.java	90.83% <0.00%> (+0.27%)	7.00% <0.00%> (ø%)
...main/java/reactor/core/publisher/FluxIterable.java	78.12% <0.00%> (+0.69%)	13.00% <0.00%> (ø%)
...c/main/java/reactor/core/publisher/MonoCreate.java	74.24% <0.00%> (+0.75%)	3.00% <0.00%> (ø%)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b85926...11992a5. Read the comment docs.