-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2023 by handling "empty Callable
" case in Flux#collectList
#2024
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.2.x #2024 +/- ##
============================================
+ Coverage 84.61% 84.62% +0.01%
- Complexity 3966 3968 +2
============================================
Files 364 364
Lines 30177 30178 +1
Branches 5611 5612 +1
============================================
+ Hits 25533 25537 +4
+ Misses 3037 3035 -2
+ Partials 1607 1606 -1
Continue to review full report at Codecov.
|
return Mono.onAssembly(new MonoSupplier<>(listSupplier())); | ||
} | ||
return Mono.just(v).map(u -> { | ||
return Mono.fromCallable(() -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to use the form onAssembly(new MonoCallable<>(...))
here and below, so that there is no additional step in the backtrace that corresponds to the fromCallable
call.
@bsideup this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
It seems that we were handling
Callable
(but notFuseable.ScalarCallable
) incorrectlyand, instead of producing an empty list, were returning an empty
Mono
instead.The change also simplifies handling of
Fuseable.ScalarCallable