Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish windowUntilChanged predicate cleanup on cancel #1901

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

simonbasle
Copy link
Member

No description provided.

@simonbasle simonbasle changed the title more cleanup around cancellation FluxWindowPredicate and windowUntilChanged: more cleanup around cancellation Sep 20, 2019
@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #1901 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1901      +/-   ##
============================================
+ Coverage      81.5%   81.56%   +0.06%     
+ Complexity     3971     3970       -1     
============================================
  Files           373      373              
  Lines         30765    30769       +4     
  Branches       5792     5792              
============================================
+ Hits          25074    25098      +24     
+ Misses         4086     4075      -11     
+ Partials       1605     1596       -9
Impacted Files Coverage Δ Complexity Δ
...va/reactor/core/publisher/FluxWindowPredicate.java 89.19% <100%> (+0.1%) 3 <0> (ø) ⬇️
...ain/java/reactor/core/scheduler/SchedulerTask.java 75% <0%> (-1.79%) 17% <0%> (ø)
...r-core/src/main/java/reactor/core/Disposables.java 88.95% <0%> (-1.23%) 21% <0%> (ø)
...c/main/java/reactor/core/publisher/FluxReplay.java 83.99% <0%> (-0.16%) 27% <0%> (-1%)
.../main/java/reactor/core/publisher/FluxFlatMap.java 95.14% <0%> (+0.18%) 19% <0%> (ø) ⬇️
...ain/java/reactor/core/publisher/FluxConcatMap.java 90% <0%> (+0.27%) 7% <0%> (ø) ⬇️
...rc/main/java/reactor/core/publisher/Operators.java 79.88% <0%> (+0.7%) 125% <0%> (ø) ⬇️
...in/java/reactor/core/publisher/FluxWindowWhen.java 81.73% <0%> (+1.92%) 2% <0%> (ø) ⬇️
...actor/core/publisher/FluxOnBackpressureLatest.java 83.5% <0%> (+3.09%) 2% <0%> (ø) ⬇️
...va/reactor/core/publisher/ParallelMergeReduce.java 72.95% <0%> (+3.27%) 3% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d636d...03c3bb9. Read the comment docs.

@simonbasle simonbasle marked this pull request as ready for review September 20, 2019 11:25
@simonbasle
Copy link
Member Author

@reactorbot fast track

Copy link

@reactorbot reactorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-track requested by @simonbasle

@simonbasle simonbasle changed the title FluxWindowPredicate and windowUntilChanged: more cleanup around cancellation Polish windowUntilChanged predicate cleanup on cancel Sep 20, 2019
@simonbasle simonbasle merged commit f705674 into master Sep 20, 2019
@simonbasle simonbasle deleted the polishStateDisposeOnCancel branch September 20, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants