Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reactor-tools into the core repository #1731

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Conversation

bsideup
Copy link
Contributor

@bsideup bsideup commented Jun 3, 2019

Imported from https://github.com/reactor/reactor-tools

(I did not touch the implementation to make the review easier, will follow up with a few cleanups)

@bsideup bsideup added type/enhancement A general enhancement type/chores A task not related to code (build, formatting, process, ...) labels Jun 3, 2019
@bsideup bsideup added this to the 3.3.0.M2 milestone Jun 3, 2019
@bsideup bsideup requested review from smaldini and simonbasle June 3, 2019 16:46
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for a move of the module from its own repo to the core repo 👍

@codecov-io
Copy link

Codecov Report

Merging #1731 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1731      +/-   ##
============================================
+ Coverage     81.87%   81.93%   +0.05%     
+ Complexity     3801     3799       -2     
============================================
  Files           362      362              
  Lines         30047    30120      +73     
  Branches       5593     5632      +39     
============================================
+ Hits          24602    24678      +76     
+ Misses         3901     3898       -3     
  Partials       1544     1544
Impacted Files Coverage Δ Complexity Δ
...ain/java/reactor/core/scheduler/SchedulerTask.java 68.42% <0%> (-5.27%) 12% <0%> (-1%)
...rc/main/java/reactor/core/publisher/Operators.java 80.33% <0%> (-0.15%) 125% <0%> (-1%)
...in/java/reactor/core/publisher/FluxBufferWhen.java 92.08% <0%> (+0.35%) 2% <0%> (ø) ⬇️
.../main/java/reactor/core/publisher/FluxFlatMap.java 94.78% <0%> (+0.38%) 13% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxCreate.java 83.37% <0%> (+0.48%) 8% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxReplay.java 85.77% <0%> (+1.45%) 25% <0%> (ø) ⬇️
.../java/reactor/core/scheduler/ElasticScheduler.java 85.24% <0%> (+1.63%) 26% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c154a1...a3d738d. Read the comment docs.

@smaldini
Copy link
Contributor

smaldini commented Jun 3, 2019

LGTM we will work on the improvements themselves post M2

@simonbasle simonbasle changed the title Import reactor-tools Move reactor-tools into the core repository Jun 4, 2019
@simonbasle simonbasle merged commit 8316531 into master Jun 4, 2019
@simonbasle simonbasle deleted the reactor-tools branch June 4, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chores A task not related to code (build, formatting, process, ...) type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants