Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests in build: less verbosity, fix compiler warnings #1139

Merged
merged 5 commits into from
Mar 22, 2018
Merged

Improve tests in build: less verbosity, fix compiler warnings #1139

merged 5 commits into from
Mar 22, 2018

Conversation

simonbasle
Copy link
Member

@smaldini to be rebase-merged.

  • [test] Fix compiler warnings during compileTestJava phase
  • [test] Allow re-run of failed tests (empty test suite due to filters)
  • [test] Make test logs less verbose by only displaying details of FAILED
  • [test} Fix compiler warnings during compileJava phase
  • [test] Remove seemingly useless test.resources srcDir declaration

@simonbasle
[test] Remove seemingly useless test.resources srcDir config (#1139)
3e0622b
@simonbasle
[test] Fix compiler warnings during compileJava phase (#1139)
8921c2e 
Use `@SuppressWarnings` rather than IntelliJ comments when possible so
that the compiler will pick these hints up too.
@simonbasle
[test] Make test less verbose by only displaying FAILED (#1139)
95e49f5 
The PASSED were displayed in case a test would hang and the CI would
terminate the build without much info. If such situation arises again,
one can always add PASSED back temporarily.

Ideally, gradle/gradle#1096 and/or
gradle/gradle#2476 being fixed would improve
the situation.
@simonbasle
[test] Allow re-run of failed tests (fully filtered test suite, #1139)
22399df 
This commit prevents test failure when no tests are found due to a too
restrictive filter. This will notably happen when failed tests are
re-run from the IDE, leading to an enumeration of the tests to run that
won't match the includes of additional test tasks like testNG.

Additionally, a small test report is printed for each test task,
giving status of the intermediate states of the global check task.
@simonbasle
[test] Fix compiler warnings during compileTestJava phase (#1139)
78fa10d 
Use `@SuppressWarnings` rather than IntelliJ comments when possible so
that the compiler will pick these hints up too.
@codecov-io
Copy link

codecov-io commented Mar 21, 2018 •
edited
Loading

Codecov Report

Merging #1139 into master will increase coverage by 0.01%.
The diff coverage is 89.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1139      +/-   ##
============================================
+ Coverage     83.66%   83.68%   +0.01%     
- Complexity     3603     3616      +13     
============================================
  Files           337      337              
  Lines         27806    27826      +20     
  Branches       5196     5198       +2     
============================================
+ Hits          23265    23287      +22     
- Misses         2980     2983       +3     
+ Partials       1561     1556       -5
Impacted Files Coverage Δ Complexity Δ
.../reactor/core/publisher/OnNextFailureStrategy.java 82.69% <ø> (ø) 6 <0> (ø) ⬇️
...ain/java/reactor/core/publisher/MonoProcessor.java 73.39% <ø> (ø) 81 <0> (ø) ⬇️
...e/src/main/java/reactor/core/publisher/Signal.java 85.71% <ø> (ø) 31 <0> (ø) ⬇️
...in/java/reactor/core/publisher/FluxWindowWhen.java 81.73% <0%> (+1.05%) 2 <0> (ø) ⬇️
.../java/reactor/core/publisher/FluxMergeOrdered.java 97.82% <100%> (+0.03%) 10 <0> (ø) ⬇️
...java/reactor/core/publisher/FluxIndexFuseable.java 79.1% <100%> (+0.31%) 3 <0> (ø) ⬇️
...tor-core/src/main/java/reactor/core/Scannable.java 92.68% <100%> (+0.09%) 18 <0> (ø) ⬇️
...ain/java/reactor/core/publisher/MonoCacheTime.java 84.34% <100%> (+0.27%) 10 <0> (ø) ⬇️
...ore/src/main/java/reactor/core/publisher/Flux.java 99.86% <100%> (ø) 502 <1> (ø) ⬇️
.../java/reactor/core/publisher/BlockingIterable.java 70.52% <0%> (-6.32%) 6% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c7c50...78fa10d. Read the comment docs.

@simonbasle simonbasle added the for/fast-track Instructs the bot to fast track (internal) label Mar 22, 2018
reactorbot
reactorbot approved these changes Mar 22, 2018
View reviewed changes
Copy link

@reactorbot reactorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-track requested by @simonbasle

@simonbasle simonbasle merged commit 63debe7 into master Mar 22, 2018
simonbasle added a commit that referenced this pull request Mar 22, 2018
@simonbasle
[test] Remove seemingly useless test.resources srcDir config (#1139)
946ac4a
simonbasle added a commit that referenced this pull request Mar 22, 2018
@simonbasle
[test] Fix compiler warnings during compileJava phase (#1139)
2e9f9e0 
Use `@SuppressWarnings` rather than IntelliJ comments when possible so
that the compiler will pick these hints up too.
simonbasle added a commit that referenced this pull request Mar 22, 2018
@simonbasle
[test] Make test less verbose by only displaying FAILED (#1139)
8d6112e 
The PASSED were displayed in case a test would hang and the CI would
terminate the build without much info. If such situation arises again,
one can always add PASSED back temporarily.

Ideally, gradle/gradle#1096 and/or
gradle/gradle#2476 being fixed would improve
the situation.
simonbasle added a commit that referenced this pull request Mar 22, 2018
@simonbasle
[test] Allow re-run of failed tests (fully filtered test suite, #1139)
4b74091 
This commit prevents test failure when no tests are found due to a too
restrictive filter. This will notably happen when failed tests are
re-run from the IDE, leading to an enumeration of the tests to run that
won't match the includes of additional test tasks like testNG.

Additionally, a small test report is printed for each test task,
giving status of the intermediate states of the global check task.
simonbasle added a commit that referenced this pull request Jun 6, 2018
@simonbasle
port [test] Fix compiler warnings during compileTestJava phase (#1139)
9020acf 
Use `@SuppressWarnings` rather than IntelliJ comments when possible so
that the compiler will pick these hints up too.

This is a backport of commit 63debe7, as tracked in #1198
@smaldini smaldini mentioned this pull request Jun 6, 2018
Closed
11 tasks
@simonbasle simonbasle deleted the build-cleanup branch June 15, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reactorbot reactorbot reactorbot approved these changes

Assignees
No one assigned
Labels
for/fast-track Instructs the bot to fast track (internal)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonbasle @codecov-io @reactorbot