Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Improve build configuration for tests #1007

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Conversation

simonbasle
Copy link
Member

  • better common configuration
  • clearer sequencing of events
  • additional tests are more clearly segregated
    and will still run when explicitly called
  • testNG is only exluded from check when
    building on Travis
  • loops is always excluded from check when
    building a SNAPSHOT
  • Travis fast_finish: do not wait for JDK9
    job to finish before setting the build status

 - better common configuration
 - clearer sequencing of events
 - additional tests are more clearly segregated
   and will still run when explicitly called
 - testNG is only exluded from check when
   building on Travis
 - loops is always excluded from check when
   building a SNAPSHOT
 - Travis fast_finish: do not wait for JDK9
   job to finish before setting the build status
@simonbasle simonbasle added the type/chores A task not related to code (build, formatting, process, ...) label Jan 4, 2018
@simonbasle simonbasle added this to the 3.1.3.RELEASE milestone Jan 4, 2018
@simonbasle simonbasle requested a review from smaldini January 4, 2018 10:43
@codecov-io
Copy link

codecov-io commented Jan 4, 2018

Codecov Report

Merging #1007 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1007      +/-   ##
============================================
+ Coverage     83.67%   83.72%   +0.04%     
- Complexity     3390     3392       +2     
============================================
  Files           328      328              
  Lines         26744    26744              
  Branches       4937     4937              
============================================
+ Hits          22379    22391      +12     
+ Misses         2882     2875       -7     
+ Partials       1483     1478       -5
Impacted Files Coverage Δ Complexity Δ
...ain/java/reactor/core/publisher/MonoPublishOn.java 88.33% <0%> (-3.34%) 2% <0%> (ø)
...c/main/java/reactor/core/publisher/RingBuffer.java 70.56% <0%> (-0.95%) 24% <0%> (ø)
...rc/main/java/reactor/core/publisher/Operators.java 72.15% <0%> (+0.18%) 84% <0%> (+1%) ⬆️
...ava/reactor/core/publisher/WorkQueueProcessor.java 70.08% <0%> (+0.42%) 19% <0%> (ø) ⬇️
...ain/java/reactor/core/publisher/FluxPublishOn.java 87.84% <0%> (+0.62%) 5% <0%> (ø) ⬇️
...eactor/core/publisher/ParallelMergeSequential.java 81.34% <0%> (+1.03%) 7% <0%> (ø) ⬇️
.../java/reactor/core/scheduler/ElasticScheduler.java 90.62% <0%> (+2.08%) 20% <0%> (ø) ⬇️
...va/reactor/core/publisher/ParallelMergeReduce.java 71.9% <0%> (+3.3%) 3% <0%> (ø) ⬇️
...c/main/java/reactor/core/scheduler/WorkerTask.java 83.01% <0%> (+3.77%) 20% <0%> (+1%) ⬆️
.../java/reactor/core/publisher/FluxLimitRequest.java 98% <0%> (+4%) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f0e22...223218a. Read the comment docs.

@simonbasle simonbasle merged commit b9e3aa9 into master Jan 4, 2018
@smaldini smaldini deleted the improveBuildTests branch January 10, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants