Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Kotlin-Gradle-Plugin 1.1.60 when available #915

Closed
simonbasle opened this issue Oct 21, 2017 · 1 comment
Closed

Upgrade to Kotlin-Gradle-Plugin 1.1.60 when available #915

simonbasle opened this issue Oct 21, 2017 · 1 comment
Assignees
@simonbasle
Labels
area/kotlin This belongs to the kotlin theme status/on-hold This was set aside or cannot be worked on yet type/chores A task not related to code (build, formatting, process, ...) type/enhancement A general enhancement
Milestone
3.1.3.RELEASE

Comments

@simonbasle
Copy link
Member

Follow-up to #887:

  • upgrade to the 1.1.60 version when available
  • verify it fixes the duplicate entries in sources jar ( unzip reactor-core-3.1.2.BUILD-SNAPSHOT-sources.jar -d ./temp)
  • verify it doesn't cause any other issue
  • remove the "IGNORE_DUPLICATES" workaround from the build.gradle
  • do the same for reactor-addons
@simonbasle simonbasle added type/chores A task not related to code (build, formatting, process, ...) type/enhancement A general enhancement area/kotlin This belongs to the kotlin theme labels Oct 21, 2017
@simonbasle simonbasle added this to the 3.1.2.RELEASE milestone Oct 21, 2017
@simonbasle simonbasle self-assigned this Oct 21, 2017
@simonbasle simonbasle added the status/on-hold This was set aside or cannot be worked on yet label Oct 21, 2017
@simonbasle simonbasle mentioned this issue Oct 21, 2017
Closed
@simonbasle
Copy link
Member Author

(or maybe we should keep the workaround as an additional security measure)

simonbasle added a commit to reactor/reactor-addons that referenced this issue Nov 24, 2017
@simonbasle
[build] Bump wrapper to 4.2, update kotlin and shadowJar plugins
dcc0c45 
See reactor/reactor-core#915

This commit attempts at fixing the issue with sourceJar duplication,
now that kotlin plugin has a 1.1.60 version. After bumping the kotlin
plugin, the issue still manifested. Apparently the Gradle Wrapper was
still in version 2.8 and that had an impact.

Bumping gradlew to 4.2 and as a consequence shadowJar to 2.0.1 seems
to fix the issue, and the sourceJar can now be guarded against future
duplication issues by using a FAIL strategy.
@simonbasle simonbasle mentioned this issue Nov 24, 2017
Merged
simonbasle added a commit that referenced this issue Nov 24, 2017
@simonbasle
fix #915 Bump Kotlin plugin to 1.1.60 and FAIL on dup sources in jar
ff92c5d
simonbasle added a commit to reactor/reactor-addons that referenced this issue Nov 27, 2017
@simonbasle
[build] Update kotlin, bump wrapper to 4.2 and shadowJar plugin (#134)
ee7176f 
See reactor/reactor-core#915

This commit attempts at fixing the issue with sourceJar duplication,
now that kotlin plugin has a 1.1.61 version. After bumping the kotlin
plugin, the issue still manifested. Apparently the Gradle Wrapper was
still in version 2.8 and that had an impact.

Bumping gradlew to 4.2 and as a consequence shadowJar to 2.0.1 seems
to fix the issue, and the sourceJar can now be guarded against future
duplication issues by using a FAIL strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
area/kotlin This belongs to the kotlin theme status/on-hold This was set aside or cannot be worked on yet type/chores A task not related to code (build, formatting, process, ...) type/enhancement A general enhancement
Projects
None yet
Milestone
3.1.3.RELEASE
Development

No branches or pull requests
1 participant
@simonbasle