Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with JDK9 additionally to JDK8 in Travis, fix the build and tests #891

Closed
2 tasks done
simonbasle opened this issue Oct 3, 2017 · 0 comments
Closed
2 tasks done

Build with JDK9 additionally to JDK8 in Travis, fix the build and tests #891

simonbasle opened this issue Oct 3, 2017 · 0 comments
Labels
area/java9 This belongs to the java9 compatibility theme type/chores A task not related to code (build, formatting, process, ...) type/documentation A documentation update

Comments

@simonbasle
Copy link
Member

simonbasle commented Oct 3, 2017 •
edited
Loading

@simonbasle simonbasle added type/chores A task not related to code (build, formatting, process, ...) type/documentation A documentation update area/java9 This belongs to the java9 compatibility theme labels Oct 3, 2017
@simonbasle simonbasle changed the title Reactivate PDF asciidoctor export with JDK9 Build with JDK9 additionally to JDK8 in Travis, fix the build and tests Oct 3, 2017
@simonbasle simonbasle mentioned this issue Oct 3, 2017
Closed
simonbasle added a commit that referenced this issue Oct 4, 2017
@simonbasle
[build] Fix #891 Mostly build under JDK9, add JDK9 build in Travis CI
4590e69 
This commit builds under both JDK8 and JDK9 in Travis CI.
Minus a couple of caveats, it fixes the JDK9 build with various changes:

Version Bumps
 - Update to Gradle 4.2.1 for full compatibility with JDK9
 - Bump asciidoctor plugin^[1]
 - Bump Mockito^[2] and Jacoco to their latest JDK9-compatible versions
 - Bump AssertJ to 3.8.0^[3]
 - Bump Kotlin Gradle Plugin to 1.5.51^[4]

[1] Asciidoctor Caveat:
***********************
In JDK9, don't build the PDF as no compatible combination of
asciidoctorJ-pdf could be found...

[2] Tests Adaptation, Mockito Caveats:
**************************************
Fix scan tests that use mocks of non-Scannable PARENTs/ACTUALs

Added MockUtils with interfaces that help creating Scannable mocks that
also implement another interface for combinations not naturally found in
production code.

See Mockito issue mockito/mockito#357, which
is probably the cause why these used to pass on JDK 8.

[3] AssertJ Caveat:
*******************
Added workaround to an AssertJ issue in Java 8, see:
assertj/assertj#1046

[4] Kotlin Caveats:
*******************
 - Fixed building of Javadoc under JDK9 polluted by Kotlin classes that
 are deemed invalid by the Java 9 doclet. (these used to be ignored in
 Java 8)
 - Dokka is not building, so we exclude kdocZip (and thus dokka) under
 JDK9 (see Kotlin/dokka#220)
simonbasle added a commit that referenced this issue Oct 5, 2017
@simonbasle
#891 Add limitRequest to precisely cap the request to upstream
8684541
simonbasle added a commit that referenced this issue Oct 11, 2017
@simonbasle
#891 Add limitRequest to precisely cap the request to upstream
429321d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/java9 This belongs to the java9 compatibility theme type/chores A task not related to code (build, formatting, process, ...) type/documentation A documentation update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonbasle