Ability to build with Java 9 #1326
Labels
Milestone
Comments
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 21, 2018
Due to different stacktrace. Java 9 inserts 2 more lines in the middle: java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 21, 2018
Casting even empty Objects[] to Integer[] results in: java.lang.ClassCastException: java.base/[Ljava.lang.Object; cannot be cast to java.base/[Ljava.lang.Integer; (verified by QueuesTest.toArrayOnZeroQueueShouldNotFailAlsoOnJava9() and zeroQueueOperations()). For empty queue. The production implementation was changed (and also slightly simplified). The same problem is also with the other Queue implementations. Will be fixed separately.
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 21, 2018
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 21, 2018
simonbasle
added
type/bug
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 22, 2018
It was failing with ClassCastException on toArray([]) conversion. More tests added.
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 22, 2018
It was failing with ClassCastException on toArray([]) conversion. More tests added.
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 22, 2018
It was failing with ClassCastException on toArray([]) conversion. More tests added.
szpak
added a commit
to szpak-forks/reactor-core
that referenced
this issue
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
It would be good to be able to build the project with Java 9.
Actual behavior
Currently there are failing tests.
Extra notes
It is a prerequisite to the official Java 9(+) support in reactor-core (which - having Java 11 LTS knocking at the door - become an important thing). I haven't found any related issue, but I believe you have it in your plans (there is more work to do to achieve that).
Reactor Core version
current master
JVM version (e.g.
java -version)OpenJDK Runtime Environment (build 9.0.4+11)
The text was updated successfully, but these errors were encountered: