Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MpscLinkedQueue is public (it shouldn't) #1035

Closed
smaldini opened this issue Jan 23, 2018 · 0 comments
Closed

MpscLinkedQueue is public (it shouldn't) #1035

smaldini opened this issue Jan 23, 2018 · 0 comments
Labels
type/bug A general bug warn/api-change Breaking change with compilation errors
Milestone
3.1.4.RELEASE

Comments

@smaldini
Copy link
Contributor

MpscLinkedQueue should only be created by a Queues factory like all other queues.
@smaldini smaldini added the warn/api-change Breaking change with compilation errors label Jan 23, 2018
@smaldini smaldini added this to the 3.1.4.RELEASE milestone Jan 23, 2018
@smaldini smaldini added the type/bug A general bug label Jan 23, 2018
@smaldini smaldini mentioned this issue Jan 23, 2018
Closed
simonbasle added a commit that referenced this issue Jan 23, 2018
@simonbasle
fix #1035 Hide MPSC queue implementation behind Queues Supplier
4c792f5 
The MpscLinkedQueue was another class that shouldn't have been released
as public. It is now package private, and the new Queues method
`multiProducerUnbouded()` should be used instead.

This also closes #1010 again.
simonbasle added a commit that referenced this issue Jan 23, 2018
@simonbasle
fix #1035 Make MPSC queue implementation package private
19932cd 
The `MpscLinkedQueue` was another class that shouldn't have been
released as public. It is now package private, since all access have
been converted to the new Queues.unboundedMultiproducer() method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug A general bug warn/api-change Breaking change with compilation errors
Projects
None yet
Milestone
3.1.4.RELEASE
Development

No branches or pull requests
1 participant
@smaldini