support to Expo #486
Merged
support to Expo #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 7, 2025 13:41
sunnylqm
reviewed
Apr 8, 2025
| apply plugin: 'com.android.library' | ||
| if (isNewArchitectureEnabled()) { | ||
| apply plugin: 'com.facebook.react' | ||
| } | ||
|
|
||
| if (expoProject) { | ||
| group = 'expo.modules.pushy' | ||
| version = '1.0.0' |
There was a problem hiding this comment.
这个version应该可以从package.json中读取吧
There was a problem hiding this comment.
expo.modules.pushy属于native代码，不应该读取package.json里面的版本号吧，这里的逻辑借鉴的是
group = 'cn.reactnative.modules.update'
version = '1.0.0'
sunnylqm
reviewed
Apr 8, 2025
.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| 18 | |||
sunnylqm
reviewed
Apr 8, 2025
yarn.lock
Outdated
There was a problem hiding this comment.
yarn lock文件去掉，这边的仓库目前统一用bun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support to Expo.