Skip to content

Fixed broken placeholder links on manipulating dom with refs page #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daniel-norris
Copy link

@daniel-norris daniel-norris commented Jun 15, 2025

Hi, was looking at the page below and noticed a couple things...

  • the image placeholders we're retrieving from placecats.com is no longer working and I can't find the API documentation anymore
  • the images used for some of the other ref examples and solutions were all using the same image

image

image

image

Solution:

  • I've pointed all the examples to a new placeholder
  • They now generated an assortment of images and not just one
  • They're all dogs because dogs > cats

image

image

image

🐕‍🦺

@facebook-github-bot
Copy link
Collaborator

Hi @daniel-norris!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@gaearon
Copy link
Member

gaearon commented Jun 16, 2025

I think we should just host them ourselves and do a pass to remove any external image links from the docs. Would you mind taking a look at that?

I'd also prefer to keep cats personally. But if you do the above, I can take dogs.

@gaearon
Copy link
Member

gaearon commented Jun 16, 2025

One argument to keep cats is to avoid churning the translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants