Removed misleading code in Sharing State Between Components page #6700
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @Mavludin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
Can be closed. A duplicate of #6657 |
@Mavludin I think you, as the PR author, have the proper permissions to close it yourself. 😄 The button should look like this:
Thanks! ❤️ |
This pull request introduces the fix where I removed misleading code in the
Sharing State Between Componentspage. With this fix, when the learners reach theStep 2: Pass hardcoded data from the common parentsection, they will no longer see the piece of code that is not supposed to be there.Key Changes:
Removed the
setIsActivefunction and its onClick handler in thePanelcomponent.Rationale:
The
Panelcomponent doesn't know about thesetIsActivefunction, so it shouldn't be there.Testing and Validation:
Conducted tests with
yarn check-all. and made sure the functionality and UI behave as expected.Verified that the component maintains its performance and responsiveness across different devices and browsers.