Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] : added next/image component as MDX component #5546

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shanudjn
Copy link

@shanudjn shanudjn commented Feb 5, 2023

This PR is for the issue #4382

The PR contains:

  1. Replacing img tag with next/image for IllustraionBlock and Illustration components
  2. Added width and height in the places where the above mentioned components were used.

Assumption-

The values for width and height for the images were taken from the main beta documentation. I woud like to know if its the right way to set the width and height. Will will change it if its required.

Screenshots for sample

Sample 1 Sample 2
Capture Capture2

@facebook-github-bot
Copy link
Collaborator

Hi @shanudjn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 43.62 KB (🟡 +11 B) 132.81 KB
/500 43.6 KB (🟡 +11 B) 132.79 KB
/[[...markdownPath]] 43.79 KB (🟡 +11 B) 132.97 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@shanudjn shanudjn changed the title add: Image component for IllustrationBlock add: next/image component as MDX component Feb 6, 2023
@shanudjn shanudjn changed the title add: next/image component as MDX component [beta] : added next/image component as MDX component Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants