Skip to content

Update focus managing section #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

theKashey
Copy link

A few reasons to update this section:

  • Focus and Scroll Locks are very dangerous tools. They could completely "lock" customer, and not let them properly use an application.
  • The section does not explain why they could be necessary.
  • react-aria-modal was not a great example, as long as it does not work properly on iOS, will prevent operations with portaled context(dropdowns), and does not explain how focus could be managed.

PS: while scroll lock(no-scroll) was a part of react-aria-modal, I am not mentioning it here, as long as this is a wrong section for it.

Reasons to mention react-focus-lock(TLDR - it just works):

  • does not prevent "clicking" on elements outside the lock and does not fight with other focus-lock solutions (incidents free)
  • works with portals
  • works with any possible tabIndexes, and locks scattered to multiple nodes

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 791b8df

https://deploy-preview-1601--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants