Repository navigation
className default is lost when props.className is undefined in UncontrolledTabs #581
Description
Activity
Hi, thanks for the clear report.
I’m interested in working on this, but wanted to confirm expected behavior before proposing a fix:
Should the defaultclassNamebe preserved whenprops.classNameisundefined?
Or is the current behavior intentional, and the fix would require guarding against explicitundefinedoverrides?Depending on the answer, I can propose a backward-compatible fix and add tests.
It is inteded that when the
classNameis set to a string it should overwrite. If it is set to undefined and null it should not.Thanks for confirming! I’ll work on a fix that preserves the default className when props.className is null or undefined, and add tests to cover this behavior.
In the UncontrolledTabs component, default props are merged using object spreading:
const { className, ...attributes } = { ...defaultProps, ...props, };Even the defaultProps.className is defined ('react-tabs') and props.className is explicitly undefined, the spread operation will overwrite the default and set className to undefined.
As a result, the default class name is lost. It's unclear whether this behavior is intended, but it can lead to unexpected issues, especially when upgrading from older versions where the default class was always applied. Projects relying on the default 'react-tabs' class for styling or selectors may break silently.