Skip to content

Why are <li> being used as the clickable items #361

Description

@harryhaigh

Isn't it best practice to use <button> instead of <li> as the clickable elements for tabs. If this library is focused on accessibility then why isn't it following best practices?

Activity

  1. AgmarTorres commented on May 20, 2021

    @AgmarTorres

    I agree, maybe we can refactore this part with a different way to do a clickable tag.

  2. pookmish commented on Jun 22, 2023

    @pookmish

    I just had an accessibility review performed on a page using this library. This issue was called out. Replacing or even nesting with a button would solve the problem. Unfortunately I don't see any way to alter the <Tab> component either to make it work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions