Skip to content

Changed Let to Var #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Changed Let to Var #1027

merged 1 commit into from
Sep 26, 2019

Conversation

edisonaugusthy
Copy link
Contributor

Changed Let to Var to avoid breaking down in older browsers
Will fix #1026

Changed Let to Var to avoid breaking down in older browsers
Will fix reactjs#1076
@BookOfGreg
Copy link
Member

Pretty frustrating that webpack-cli is bust at the moment but I see that this will fix the let issue for now.
I want to look into ways to avoid accidentally using new ES6 features in the future, either by compiling with babel for sprockets users or by some linting/tests/warning.

@BookOfGreg BookOfGreg merged commit e2a50f0 into reactjs:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let breaks old browsers
2 participants