This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Fix to address a performance-related issue wherein the Javascript init bundle is executed each time getMarkup() is called#7
Merged
zpao merged 2 commits intoreactjs:masterfrom May 26, 2015
Conversation
initialisation code is executed **each time** ReactJS::getMarkup() is called. I cannot see a good reason why this should be the case, and my thinking is that the concatenated code bundle should be executed once only - when ReactJS is instantiated. This way, ReactJS::getMarkup() is only responsible for executing the JS React.renderToString() method, rather than executing the whole vendor bundle first, and then calling .renderToString() - which is incredibly costly and slow!
jbroadice
changed the title
jbroadice
changed the title
jbroadice
changed the title
jbroadice
changed the title
Member
|
I think this makes sense and is pretty similar to what we do in react-rails. Let's do it. |
zpao
added a commit
that referenced
this pull request
May 26, 2015
Fix to address a performance-related issue wherein the Javascript init bundle is executed each time getMarkup() is called
Contributor
Author
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix addresses an issue where the concatenated Javascript initialisation code is executed each time
ReactJS::getMarkup()is called. I cannot see a good reason why this should be the case, and my thinking is that the concatenated code bundle should be executed once only - when ReactJS is instantiated.This way,
ReactJS::getMarkup()is only responsible for executing the JSReact.renderToString()method, rather than executing the whole initialisation bundle first, and then calling.renderToString()- which seems to be incredibly costly and slow!This change dramatically speeds up things for me on pages with multiple separate calls to render React components.