This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Conversation
|
@zpao Yes, that works. returns |
Contributor
|
Some news about when it will get merged? |
|
We want this got merged please. |
|
We need this pull request to be merged please. |
|
Any news on this one? |
Member
Author
|
Sorry for the delay. I think I might end up doing this slightly differently now that we ship react-dom-server.js which has the API we want, as opposed to building our own package (even though that is easy). I'll take a look today. |
Just in case... The bundle approach is preferred since a build step will likely be necessary regardless and can be integrated into other processes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates ReactJS.php to require that the provided
libsrcalso hasReactDOMandReactDOMServerexposed as globals. I think this ultimately is the best path forward for the time being.I updated the example to build such a bundle. But I don't have PHP set up right to run this so I haven't actually tested this. Anybody want to sanity check this?
CC people who have filed issues recently @Finetuned @daslicht @tauseefk