Skip to content

[fixed] Local development environment - #754

Merged
diasbruno merged 2 commits into
masterfrom
unknown repository
May 27, 2019
Merged

[fixed] Local development environment#754
diasbruno merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented May 26, 2019

Copy link
Copy Markdown

Fixes #744

Changes proposed:

  • Downgraded webpack-dev-server to 2.11.5 which is the latest version that supports webpack 3

Upgrade Path (for changed or removed APIs): N/A

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

gados3 added 2 commits May 26, 2019 16:34
Downgraded webpack-dev-server to 2.11.5
Installed missing dependencies
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 86.621% when pulling 1005f46 on gados3:fix/744/local-dev-environment into a2838bb on reactjs:master.

@diasbruno

Copy link
Copy Markdown
Collaborator

Hi @gados3, thanks for the PR. This is legit. I was checking the v2+ family, but 2.11.5 tag is not listed, but it is available on npm. Probably, they forgot to upload the tag.

@diasbruno

diasbruno commented May 27, 2019

Copy link
Copy Markdown
Collaborator

You can open an issue there (just to warn them about this).

@diasbruno
diasbruno merged commit 6ff8d85 into reactjs:master May 27, 2019
@diasbruno

Copy link
Copy Markdown
Collaborator

Thanks, @gados3!

@gdostie

gdostie commented May 27, 2019

Copy link
Copy Markdown

@diasbruno yeah no problem, I noticed the tag by looking up on npmjs
image

@ghost
ghost deleted the fix/744/local-dev-environment branch June 1, 2019 14:06
programmer4web pushed a commit to programmer4web/react-modal that referenced this pull request Oct 5, 2020
Downgraded webpack-dev-server to 2.11.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local development cannot find module webpack-cli/bin/config-yargs

3 participants