Skip to content

[fixed] Add file extention to entry point for TypeScript importing - #294

Merged
claydiffrient merged 1 commit into
reactjs:masterfrom
kenju:add_file_extention
Dec 31, 2016
Merged

[fixed] Add file extention to entry point for TypeScript importing#294
claydiffrient merged 1 commit into
reactjs:masterfrom
kenju:add_file_extention

Conversation

@kenju

@kenju kenju commented Dec 31, 2016

Copy link
Copy Markdown
Contributor

Though this is not react-modal library's problem, here is a tweak fix necessary for TypeScript project.

Please see below post for more details:

http://stackoverflow.com/questions/41077055/typescript-2-1-feature-of-implicit-import-not-working

FYI

"Untyped imports" Section:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-1.html

// Succeeds if `node_modules/asdf/index.js` exists
import { x } from "asdf";

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@claydiffrient
claydiffrient merged commit c50f19a into reactjs:master Dec 31, 2016
@claydiffrient

Copy link
Copy Markdown
Contributor

Released in 1.6.5

@kenju

kenju commented Jan 1, 2017

Copy link
Copy Markdown
Contributor Author

@claydiffrient
Thank you 👍

@kenju
kenju deleted the add_file_extention branch January 1, 2017 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants