Skip to content

Update ModalPortal.js - #228

Merged
claydiffrient merged 1 commit into
reactjs:masterfrom
jsanchez556:patch-1
Sep 22, 2016
Merged

Update ModalPortal.js#228
claydiffrient merged 1 commit into
reactjs:masterfrom
jsanchez556:patch-1

Conversation

@jsanchez556

@jsanchez556 jsanchez556 commented Sep 21, 2016

Copy link
Copy Markdown
Contributor

Fixes #[issue number].

Changes proposed:

- Change the contentHasFocus method, in order to avoid errors in IE

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

Is necessary to change contentHasFocus() to contentHasFocus: function() in order to avoid IE errors

Is necessary to change contentHasFocus() to contentHasFocus: function() in order to avoid IE errors
@diasbruno

Copy link
Copy Markdown
Collaborator

There are other PRs that fix this issue (about focus)...but this one can be merged and other PRs can be rebased.

@claydiffrient
claydiffrient merged commit c8106f2 into reactjs:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants