Skip to content

[fixed] clear the delayed close timer when modal opens again. - #189

Merged
claydiffrient merged 2 commits into
reactjs:masterfrom
diasbruno:fix/clearTimeout
Jun 30, 2016
Merged

[fixed] clear the delayed close timer when modal opens again.#189
claydiffrient merged 2 commits into
reactjs:masterfrom
diasbruno:fix/clearTimeout

Conversation

@diasbruno

Copy link
Copy Markdown
Collaborator

Continuation of the fix #134. Look at this PR (#134) for more information.

  • added spec to validate the fix.
  • commits were not squashed to preserve the commit made by @CompuIves.

Thanks, @CompuIves.

@CompuIves

Copy link
Copy Markdown
Contributor

Thanks a lot for writing a test for it! Hopefully we can merge this soon :shipit:.

@diasbruno

Copy link
Copy Markdown
Collaborator Author

@claydiffrient can you have a look in this PR?

@claydiffrient

Copy link
Copy Markdown
Contributor

Looks good merging now

@claydiffrient
claydiffrient merged commit 13bd46e into reactjs:master Jun 30, 2016
@claydiffrient

Copy link
Copy Markdown
Contributor

Released in v1.4.0

@diasbruno
diasbruno deleted the fix/clearTimeout branch June 14, 2017 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants