[fixed] Make the non-minified dist build present again - #164
Merged
Conversation
This commit removes the `-p` flag from the call to webpack so that the webpack config works as intended, creating two files in the dist directory, one minified and one unminified. After 3f32338 was merged the build ended up only producing the production minified versions for both files. This commit restores the initial behavior of a non-minified and a minified file.
Collaborator
|
This is correct. +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163 .
Changes proposed:
Acceptance Checklist:
CONTRIBUTING.md.This commit removes the
-pflag from the call to webpackso that the webpack config works as intended, creating two
files in the dist directory, one minified and one unminified.
After 3f32338 was merged the
build ended up only producing the production minified versions
for both files. This commit restores the initial behavior
of a non-minified and a minified file.