[added] The ability to decide whether the modal should be closed when clicking the overlay area - #128
Conversation
|
Fixes: #129 |
dorsha
changed the title
|
+1 |
|
@dorsha Could you add a spec testing this feature? I generally prefer tests to be in place for code changes, especially for new functionality. |
|
@claydiffrient I added tests for the feature, please review. |
|
@dorsha would you mind squashing the three commits down to one? That would help keep the git history (and changelog) a bit more clean, especially since all three relate to the one functional change. |
|
@claydiffrient - done |
|
@dorsha It now appears that you have 5 commits in the PR. A decent guide to squashing the commits in a pull request is http://eli.thegreenplace.net/2014/02/19/squashing-github-pull-requests-into-a-single-commit if you need some guidance on what to do to make it happen. |
…licking the overlay area. This is an important ability since in some cases we don't want the modal to be closed when users are clicking outside. Added tests and README instructions.
|
@claydiffrient - now it appears as a single commit. |
|
Thanks @claydiffrient, do you have an estimation about the new release? (I want to use it in my project.) |
|
@dorsha I think we'll shoot for a release the end of next week. There is a large backlog of pull requests and issues that I want to try and work into it if possible. |
|
Cool 👍🏻 |
3 participants
This is an important ability since in some cases we don't want the modal to be closed when users are clicking outside.