Post process flow default props #231
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hold, I have a bug to work out. |
|
Ok, this is good to go and passes with the material-ui codebase. I have added every case that broke to |
rosskevin
added a commit
to alienfast/material-ui
that referenced
this pull request
Nov 20, 2017
rosskevin
added a commit
to alienfast/material-ui
that referenced
this pull request
Nov 20, 2017
rosskevin
added a commit
to mui/material-ui
that referenced
this pull request
Nov 20, 2017
* [flow] remove `type DefaultProps` * [docgen] Remove any flow type casts of default values * flow type casting now built into react-docgen reactjs/react-docgen#231 * ignore docs on theme prop * fixed changed/missing prop docs * unrecognized doc-gen flow type * changes/fixes to doc-gen * re-gen api docs with PR reactjs/react-docgen#231 * Use temp @rosskevin/react-docgen * re-gen docs - optional props should now be correct
danez
reviewed
Jan 5, 2018
| horizontal: 'left', | ||
| }: Origin), | ||
| labelRowsPerPage: ('Rows per page:': Node), | ||
| component: ('div': ElementType), |
There was a problem hiding this comment.
Out of curiosity: What is this doing?
There was a problem hiding this comment.
Casting to ElementType to avoid other flow errors and avoid typing all default props. Just one alternative. BTW We have since removed flow from our codebase.
There was a problem hiding this comment.
I see, thanks for explaining.
Yeah in my company we also dropped flow, because it was too hard to keep up and we had to add lots of workarounds and rewrite code just to make flow happy
|
I posted already in #227, seems this fixes some printing for casts too though |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
Based on the work by @adityavohra7 in #227 (on
master), I have applied a similar change tov3-devwith post processing of defaultProps. Props are not required when they are specified indefaultProps.Further, I added
component_11.jsas a diverse test case taken frommaterial-ui. It Is an all flow test that exercises required, optional, and parameterized types.Use case: mui/material-ui#9222