Add checking stateless component default props #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I just read that it probably should in a seperate handler @fkling. If you still have this opinion I can move it to a seperate handler. |
|
@fkling Could you please review this pull request? |
danez
approved these changes
Sep 22, 2016
|
Yeah, I think this is good to go, just needs to be rebased. |
CompuIves
force-pushed
the
add_stateless_defaults
branch
from
5b14b55 to
dae271c
Compare
|
Rebased! |
|
Merged! Though I don't know when we are going to release a new version yet (I just released one, I guess I should have waited 😛 ). |
|
Any idea of a new version? I need this :) |
|
I'll get something out within the next two days! (just came back from vacation) |
|
Looking forward to it! Hope you had a good one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69,
With this PR we first search for
defaultPropsof the stateless component (if stateless) and then check usingdefaultPropsorgetDefaultProps, it will overwrite thedefaultPropsof the stateless component if any is found.Let me know what you think of it, this is my first time working with AST, so I'm prepared for all feedback 😅 .