-
Notifications
You must be signed in to change notification settings - Fork 41
Fixes the main attribute of bower.json. #15
Conversation
Since ReactDOM is essential for any React project, it should be listed as one of the main files for Bower.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This seems like the right thing. I'll take a closer look at bower stuff shortly to make sure and merge then. Since bower relies on git tags though, this won't be immediately available. But well ship 0.14.1 and pick this up. |
|
Yeah. Right now, pretty much anyone who wants to use React with this package has to add the following to their This is because |
|
So the bower spec says this for
Of course bower itself doesn't do anything with these files so maybe we just do it anyway? |
|
I understand the reasoning behind that rule. OTOH, React is clearly separated into two packages, which are both necessary for pretty much any React project. I think it's a valid exception the rule, yeah. |
|
Cool, let's do it then. Thanks for the help! |
Fixes the main attribute of bower.json.
|
Any reason this isnt shipped with 0.14.0? Now I have to wait for this to work with wiredeps... |
|
Because bower is stupid. We'd have to force delete the remote tag and basically do things very much against git best practices. So it'll go out with the next release. 0.14.1 should be out today. |
|
alright then -- that works 👍 |
Since ReactDOM is essential for any React project, it should be listed as one of the main files for Bower, as per issue #14.