Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@davidgomes
Copy link
Contributor

Since ReactDOM is essential for any React project, it should be listed as one of the main files for Bower, as per issue #14.

Since ReactDOM is essential for any React project, it should be listed as one of the main files for Bower.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zpao
Copy link
Member

zpao commented Oct 22, 2015

This seems like the right thing. I'll take a closer look at bower stuff shortly to make sure and merge then. Since bower relies on git tags though, this won't be immediately available. But well ship 0.14.1 and pick this up.

@davidgomes
Copy link
Contributor Author

Yeah. Right now, pretty much anyone who wants to use React with this package has to add the following to their bower.json:

  "overrides": {
    "react": {
      "main": ["react.js", "react-dom.js"]
    }
  },

This is because ReactDOM is essential with 0.14.0.

@zpao
Copy link
Member

zpao commented Oct 22, 2015

So the bower spec says this for main (emphasis mine):

The entry-point files necessary to use your package. Only one file per filetype.

Of course bower itself doesn't do anything with these files so maybe we just do it anyway?

@davidgomes
Copy link
Contributor Author

I understand the reasoning behind that rule. OTOH, React is clearly separated into two packages, which are both necessary for pretty much any React project. I think it's a valid exception the rule, yeah.

@zpao
Copy link
Member

zpao commented Oct 23, 2015

Cool, let's do it then. Thanks for the help!

zpao added a commit that referenced this pull request Oct 23, 2015
Fixes the main attribute of bower.json.
@zpao zpao merged commit c2b7073 into reactjs:master Oct 23, 2015
@ccorcos
Copy link

ccorcos commented Oct 28, 2015

Any reason this isnt shipped with 0.14.0? Now I have to wait for this to work with wiredeps...

@zpao
Copy link
Member

zpao commented Oct 28, 2015

Because bower is stupid. We'd have to force delete the remote tag and basically do things very much against git best practices. So it'll go out with the next release. 0.14.1 should be out today.

@ccorcos
Copy link

ccorcos commented Oct 28, 2015

alright then -- that works 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants