Skip to content

Translate: understanding your ui as a tree #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

da-in
Copy link
Contributor

@da-in da-in commented Nov 19, 2023

@da-in da-in marked this pull request as draft November 19, 2023 11:48
@da-in da-in changed the title translate: understanding your ui as a tree Translate: understanding your ui as a tree Nov 19, 2023
Copy link

github-actions bot commented Nov 19, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 79.42 KB (-6 B) 183.24 KB
/500 79.41 KB (-6 B) 183.22 KB
/[[...markdownPath]] 81.13 KB (-6 B) 184.95 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Co-authored-by: Taegon Kim <gonom9@gmail.com>
@hg-pyun
Copy link
Member

hg-pyun commented Dec 19, 2023

@da-in 리뷰가 늦어서 정말정말 죄송합니다. 문장 하나가 컨플릭트가 발생하는데 확인 부탁드려도 될까요 🙏

@da-in
Copy link
Contributor Author

da-in commented Dec 19, 2023

@da-in 리뷰가 늦어서 정말정말 죄송합니다. 문장 하나가 컨플릭트가 발생하는데 확인 부탁드려도 될까요 🙏

원문에서 오타를 수정하며 발생한 conflict이며, 해결완료했습니다. 감사합니다🙂

@hg-pyun hg-pyun merged commit b6673d5 into reactjs:main Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants