Skip to content

Translate: Preserving and Resetting state#653

Merged
eomttt merged 5 commits intoreactjs:mainfrom
YOOJS1205:yoojs1205/preserving-and-resetting-state
May 21, 2023
Merged

Translate: Preserving and Resetting state#653
eomttt merged 5 commits intoreactjs:mainfrom
YOOJS1205:yoojs1205/preserving-and-resetting-state

Conversation

@YOOJS1205
Copy link
Contributor

@YOOJS1205 YOOJS1205 commented May 17, 2023

Progress

어디까지 번역을 해야할지 감이 안와서 소제목은 영어로 두었습니다.
피드백 해주시면 감사하겠습니다.

<Diagram name="preserving_state_same_component" height={461} width={600} alt="Diagram with two sections separated by an arrow transitioning between them. Each section contains a layout of components with a parent labeled 'App' containing a state bubble labeled isFancy. This component has one child labeled 'div', which leads to a prop bubble containing isFancy (highlighted in purple) passed down to the only child. The last child is labeled 'Counter' and contains a state bubble with label 'count' and value 3 in both diagrams. In the left section of the diagram, nothing is highlighted and the isFancy parent state value is false. In the right section of the diagram, the isFancy parent state value has changed to true and it is highlighted in yellow, and so is the props bubble below, which has also changed its isFancy value to true.">

Updating the `App` state does not reset the `Counter` because `Counter` stays in the same position
Counter는 같은 자리에 있기 때문에 App 상태의 갱신은 Counter를 초기화시키지 않습니다
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

백틱과 같은 문장부호도 같이 넣어주세요

- Counter는 같은 자리에 있기 때문에 App 상태의 갱신은 Counter를 초기화시키지 않습니다
+ `Counter`는 같은 자리에 있기 때문에 `App` 상태의 갱신은 `Counter`를 초기화시키지 않습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네, 확인했습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다.

지금은 선수를 바꿀 때 점수가 유지됩니다. 두 `Counter`가 같은 위치에 나타나기 때문에 React는 그들을 `person` props가 변경된 *같은* `Counter`로 봅니다.

But conceptually, in this app they should be two separate counters. They might appear in the same place in the UI, but one is a counter for Taylor, and another is a counter for Sarah.
하지만, 개념상 `app` 에는 두 개의 분리된 카운터가 있어야 합니다. 그들은 UI에 같은 위치에 나타나지만, 하나는 Taylor의 카운터이고, 다른 하나는 Sarah의 카운터입니다.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제안) "개념적으로"가 조금더 일반적인 표현 같습니다.

- 하지만, 개념상 `app` 에는 두 개의 분리된 카운터가 있어야 합니다. 
+ 하지만, 개념적으로 `app` 에는 두 개의 분리된 카운터가 있어야 합니다. 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네, 확인했습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다.

eomttt
eomttt previously approved these changes May 20, 2023
Copy link
Collaborator

@eomttt eomttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미 번역이 된 페이지를 수정하신건가요?

@YOOJS1205
Copy link
Contributor Author

이미 번역이 된 페이지를 수정하신건가요?

전부 번역이 되어있지 않아서 미비된 곳을 진행하였습니다.

@github-actions
Copy link

github-actions bot commented May 21, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.92 KB (🟢 -17 B) 170.54 KB
/500 76.91 KB (🟢 -17 B) 170.54 KB
/[[...markdownPath]] 78.34 KB (🟢 -17 B) 171.96 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@eomttt eomttt merged commit cfccc65 into reactjs:main May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants