Skip to content

Translate: <textarea> #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 10, 2023
Merged

Translate: <textarea> #605

merged 13 commits into from
May 10, 2023

Conversation

dev-rong
Copy link
Contributor

@dev-rong dev-rong commented May 1, 2023

@gnujoow
Copy link
Member

gnujoow commented May 2, 2023

@dev-rong
Copy link
Contributor Author

dev-rong commented May 3, 2023

실수로 닫았다가 다시 엽니다.

@dev-rong dev-rong reopened this May 3, 2023
@dev-rong
Copy link
Contributor Author

dev-rong commented May 3, 2023

리뷰 감사합니다. 반영하였습니다!

@dev-rong
Copy link
Contributor Author

dev-rong commented May 8, 2023

@MaxKim-J 리뷰 감사드립니다. 🙂 피드백 주신 대로 수정하는 게 모범사례에 맞고 더 자연스러운 것 같습니다. 또 이후 통일된 용어에 맞춰 reference도 레퍼런스로 수정하였습니다.

hg-pyun
hg-pyun previously approved these changes May 8, 2023
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 기여 감사드립니다 🙇‍♂️

@github-actions
Copy link

github-actions bot commented May 8, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 개행과 new line feed가 있습니다.

이 부분 수정을 요청드립니다. 원문이 업데이트 될 때, 원문과 번역의 line number로 비교를합니다. 해서 추후에 업데이트 이력을 더 잘 확인하고자 라인을 맞춰주시면 좋겠습니다.

Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
@dev-rong
Copy link
Contributor Author

dev-rong commented May 9, 2023

불필요한 개행과 new line feed가 있습니다.

이 부분 수정을 요청드립니다. 원문이 업데이트 될 때, 원문과 번역의 line number로 비교를합니다. 해서 추후에 업데이트 이력을 더 잘 확인하고자 라인을 맞춰주시면 좋겠습니다.

세심하게 짚어주셔서 감사합니다. 반영했습니다. 🙂

@hg-pyun hg-pyun merged commit d38a07d into reactjs:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants