Skip to content

Translate: <select> #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 8, 2023
Merged

Translate: <select> #597

merged 7 commits into from
May 8, 2023

Conversation

this-is-spear
Copy link
Contributor

@this-is-spear
update the <select> document
000b170 
###Description###
- Reference -> 레퍼런스
- form -> 폼
hg-pyun
hg-pyun requested changes May 5, 2023
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 ~하십시오 같은 하오체가 많이 쓰였는데, 다른 문장과 잘 어울리지 않아서 다듬어 보았습니다. 혹시 더 있다면 바꿔주시면 감사하겠습니다 🙇‍♂️

@this-is-spear
Copy link
Contributor Author

this-is-spear commented May 5, 2023 •
edited
Loading

@hg-pyun 피드백 감사합니다!
~하십시오를 사용할 지 고민을 많이 했었는데, 말씀하신 것처럼 자연스럽게 변경할 필요가 있겠네요 ☺️

~ 해주세요 보다 ~ 해야 합니다.나 ~합니다.로 수정하면 다른 문장들 처럼 ~다로 끝나 자연스러울 듯 한데, 어떠신가요? 예를 들면 value를 defaultValue로 전달해야 합니다. 처럼 변경할 수 있을 듯 합니다!

문맥에 신경쓰면 말씀하신 방법이 좋겠군요! ☺️ 수정하고 나서 다시 핑 드리겠습니다. ☺️

@this-is-spear
Copy link
Contributor Author

@hg-pyun 수정완료했습니다!

hg-pyun
hg-pyun approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영 감사합니다! LGTM

@hg-pyun hg-pyun mentioned this pull request May 8, 2023
Closed
@github-actions
Copy link

github-actions bot commented May 8, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@hg-pyun hg-pyun merged commit 482f32f into reactjs:main May 8, 2023
gnujoow
gnujoow requested changes May 8, 2023
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

고생하하셧습니다. 문서의 end 라인이 3라인정도 차이나는데 이 부분을 수정해주실 수 있을까요? 원문의 업데이트가 발생했을때 라인넘버를 보면서 확인하는데 원문의 라인넘버를 그대로 유지하면 문서유지에 도움이 됩니다. @this-is-spear

src/content/reference/react-dom/components/select.md

By default, the browser will select the first `<option>` in the list. To select a different option by default, pass that `<option>`'s `value` as the `defaultValue` to the `<select>` element.
### 초기 선택 옵션 제공 {/*providing-an-initially-selected-option*/}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

불필요한 줄바꿈이 있습니다.

gnujoow
gnujoow requested changes May 8, 2023
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

고생하하셧습니다. 문서의 end 라인이 3라인정도 차이나는데 이 부분을 수정해주실 수 있을까요? 원문의 업데이트가 발생했을때 라인넘버를 보면서 확인하는데 원문의 라인넘버를 그대로 유지하면 문서유지에 도움이 됩니다. @this-is-spear

@this-is-spear this-is-spear mentioned this pull request May 8, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnujoow gnujoow gnujoow requested changes

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno

@simsim0709 simsim0709 Awaiting requested review from simsim0709

@b9words b9words Awaiting requested review from b9words

@taggon taggon Awaiting requested review from taggon

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J

@eomttt eomttt Awaiting requested review from eomttt eomttt is a code owner

@goofcode goofcode Awaiting requested review from goofcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@this-is-spear @hg-pyun @gnujoow