Skip to content

Conversation

@mlnwns
Copy link
Contributor

@mlnwns mlnwns commented Feb 2, 2026

Context로 prop drilling 대체하기 챌린지 불필요한 영어 문장 제거

Context.js에 ImageSizeContext를 생성하고 내보냅니다. 리스트를 <ImageSizeContext.Provider value={imageSize}>로 감싸 값을 아래로 전달하고 useContext(ImageSizeContext)로 PlaceImage에서 그것을 읽습니다.

Create and export ImageSizeContext from Context.js. Then wrap the List into to pass the value down, and useContext(ImageSizeContext) to read it in the PlaceImage:

위와 같이 이미 한국어로 번역이 되었음에도, 영어 문장이 불필요하게 남아있어 제거하였습니다.

필수 확인 사항

선택 확인 사항

  • 번역 초안 작성Draft Translation
  • 리뷰 반영Resolve Reviews

Copilot AI review requested due to automatic review settings February 2, 2026 13:33
@mlnwns mlnwns requested a review from lumirlumir as a code owner February 2, 2026 13:33
@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ko-legacy-reactjs-org Ignored Ignored Preview Feb 2, 2026 2:14pm

Request Review

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant English instruction sentence from the Korean translation of the “Replace prop drilling with Context” challenge, keeping the content fully Korean as intended.

Changes:

  • Deleted the leftover English explanation line in the Solution section for the Context challenge example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1024,8 +1024,6 @@ li {

`Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext.Provider value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Context.js``ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext.Provider value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)``PlaceImage`에서 그것을 읽습니다.
`Context.js``ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)``PlaceImage`에서 그것을 읽습니다.

영어 원문이 최신 버전이라, Context에서 .Provider를 제거해주시겠어요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하고 반영했습니다! 안내해주셔서 감사합니다

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

Size changes

Details

📦 Next.js Bundle Analysis for undefined

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 기여 감사합니다!

@lumirlumir lumirlumir merged commit 2256e7d into reactjs:main Feb 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants