Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translated-thinking-in-react #239

Merged

Conversation

USKhokhar
Copy link
Contributor

@USKhokhar USKhokhar commented Jul 23, 2023

Translated entire Thinking-in-react page in Hindi.

FILE: src/content/learn/thinking-in-react.md
URL: https://hi.react.dev/learn/thinking-in-react

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review till line 56. Lets get these fixed then we can continue further with the review.

To know more about review guidelines refer #23

src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved

Start by drawing boxes around every component and subcomponent in the mockup and naming them. If you work with a designer, they may have already named these components in their design tool. Ask them!
* **सीएसएस** (CSS)--विचार करें कि आप class selectors किसके लिए बनाएँगे। (हालांकि, कंपोनेंट्स थोड़े कम सूक्ष्म होते हैं।)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove line break

src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 30, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit 57d7e14 into reactjs:main Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants