Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindi translation to this page is complete, pushing for review #175

Merged
merged 10 commits into from
Feb 17, 2022
Merged

Hindi translation to this page is complete, pushing for review #175

merged 10 commits into from
Feb 17, 2022

Conversation

lucifertrj
Copy link
Contributor

@lucifertrj lucifertrj commented Jan 10, 2022

Hindi Translation For JavaScript In JSX With Curly Brackets Is Done, Opening Pull Request For Review

@arshadkazmi42
Copy link
Member

Thank you for this @lucifertrj
I will start reviewing this ASAP.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

I have added comments till like 40.

Lets get these closed, then I will continue further with the review.
Also for our reviewing guidelines you can refer this #23

@lucifertrj
Copy link
Contributor Author

@arshadkazmi42, I have committed the changes. You can review it.

@arshadkazmi42
Copy link
Member

@arshadkazmi42, I have committed the changes. You can review it.

Thanks for the fixes @lucifertrj

I have added one comment on existing review comment. Can you check that #175 (comment)

@lucifertrj
Copy link
Contributor Author

I apologize for missing it out @arshadkazmi42. I have updated the changes

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Add review till line 113.

Lets get these fixed, then we can continue further review.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good going.

Added reviews till line 149.

Lets get these fixed, then we can continue further

@lucifertrj
Copy link
Contributor Author

@arshadkazmi42, what am I supposed to do further, I already committed the changes till line 148

@arshadkazmi42
Copy link
Member

@lucifertrj Sorry for delay. I will review the pending file ASAP.

@lucifertrj
Copy link
Contributor Author

@lucifertrj Sorry for delay. I will review the pending file ASAP.

Sorry for the inconvenience, can I know if the review is done?

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/javascript-in-jsx-with-curly-braces 221.73 KB (🟡 +1.29 KB) 314.94 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucifertrj

Added review till line 383

@lucifertrj
Copy link
Contributor Author

@lucifertrj

Added review till line 383

@arshadkazmi42 Changes done till 383

@lucifertrj
Copy link
Contributor Author

@lucifertrj

Added review till line 383
@arshadkazmi42
If possible can you review the pending lines, so that I can be assigned to another page.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on all the fixes.

I have added the review for rest of the file.

Once these are done, we can merge this PR

@arshadkazmi42
Copy link
Member

@lucifertrj you have missed few comments. can you work on those.

@lucifertrj
Copy link
Contributor Author

@lucifertrj you have missed few comments. can you work on those.

@arshadkazmi42 done

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

Thank you for working on all the fixes.

Lets get this merged 🎉

@arshadkazmi42 arshadkazmi42 merged commit 997fc40 into reactjs:main Feb 17, 2022
@lucifertrj lucifertrj deleted the translated_page_js_in_jsx branch February 18, 2022 08:10
@lucifertrj
Copy link
Contributor Author

Thank you so much, you have been a great help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants