Ensure ? is included in path variable. #1271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Cool! Not sure why CI checks are failing offhand, would you mind adding a test as well? thank you for sending this PR! |
dustinsoftware
approved these changes
Oct 23, 2021
Member
|
Released in 5.2.12, please let me know that it’s working for you @jamestyne :) |
Contributor
Author
|
Hi @dustinsoftware 5.2.12 fixes the bug and is working for us now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"?" character is not included in
request.QueryStringwhen run under .NET Framework whereas on .NET Core it does include it.This check ensures that "?" is included when path variable is set.
Closes #1270