Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serilog not handling null strings #925

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Conversation

glennawatson
Copy link
Contributor

housekeeping: Update all targets to net462, net461 no longer supported

housekeeping: Update all targets to net462, net461 no longer supported
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #925 (f603ed1) into main (476e73c) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
- Coverage   75.13%   75.03%   -0.11%     
==========================================
  Files          91       91              
  Lines        4883     4883              
==========================================
- Hits         3669     3664       -5     
- Misses       1214     1219       +5     
Impacted Files Coverage Δ
...nsions.Logging/MicrosoftExtensionsLoggingLogger.cs 86.95% <ø> (ø)
.../Splat.Raygun/RaygunFeatureUsageTrackingSession.cs 90.69% <ø> (ø)
src/Splat.Serilog/SerilogFullLogger.cs 74.78% <60.00%> (ø)
src/Splat/Logging/WrappingPrefixLogger.cs 64.70% <0.00%> (-5.89%) ⬇️
...ceMonitoring/DefaultFeatureUsageTrackingSession.cs 68.00% <0.00%> (-4.00%) ⬇️
src/Splat/Logging/WrappingFullLogger.cs 64.28% <0.00%> (-1.30%) ⬇️
src/Splat/Logging/FullLoggerExtensions.cs 27.61% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476e73c...f603ed1. Read the comment docs.

@glennawatson glennawatson merged commit 172b6f3 into main Jun 25, 2022
@glennawatson glennawatson deleted the glennawatson/fix/serilog branch June 25, 2022 00:24
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant