fix: Android DesignTimeBuild issue with MsBuild.Sdk.Extras #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Aug 17, 2019
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 71.16% 71.08% -0.09%
==========================================
Files 66 66
Lines 3676 3676
Branches 335 335
==========================================
- Hits 2616 2613 -3
- Misses 1015 1017 +2
- Partials 45 46 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Working around an Android build issue with MsBuild.Sdk.Extras
What is the current behavior?
Splat doesn't build.
What is the new behavior?
Splat builds.
What might this PR break?
Nothing that isn't already broken.