build: adopt PublicApiSharp.Analyzers for public API tracking - #4428
Open
glennawatson wants to merge 2 commits into
Open
build: adopt PublicApiSharp.Analyzers for public API tracking#4428glennawatson wants to merge 2 commits into
glennawatson wants to merge 2 commits into
Conversation
- An XML comment cannot contain '--', so the regeneration note broke every MSBuild import of src/Directory.Build.props. - Reword the note without the literal command-line switches.
ChrisPulman
approved these changes
Aug 2, 2026
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Build.
What is the new behavior?
Public API tracking moves to
PublicApiSharp.Analyzers(PAS0001-PAS0005), matching Splat.PublicAPI.txtper project per target framework, holding nested C# that reads like source. Always current - no shipped/unshipped split and no promotion step, so an API change is reviewed as the diff itself.EnablePublicApiBaseline; the package resolves the per-TFM baseline, so theAdditionalFilesglob is gone.PAS0004is enabled, so a target framework with no baseline cannot pass unnoticed.What is the current behavior?
Microsoft.CodeAnalysis.PublicApiAnalyzerswith aPublicAPI.Shipped.txt/PublicAPI.Unshipped.txtpair per target framework, andtools/generate-publicapi.*to fold one into the other.What might this PR break?
tools/generate-publicapi.sh/.ps1are removed. Regenerate withdotnet format analyzers <proj> -f <tfm> --diagnostics PAS0001 PAS0003 --severity info.*_wpftmpprojects are excluded from tracking: they sit in the real project's directory and resolve the same baseline path, so they overwrote it.Checklist
mainbranchAdditional information
Baselines were generated on Windows, which has the Apple and Android workloads. The 168 that Linux can also produce came back byte-identical, so the rendering is host-independent.