Replace Locator.Current with AppLocator.Current #4217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated all usages of Locator.Current and Locator.CurrentMutable to AppLocator.Current and AppLocator.CurrentMutable across the codebase. This change standardizes dependency resolution and improves clarity regarding the application's service locator.
glennawatson
approved these changes
Dec 4, 2025
There was a problem hiding this comment.
Pull request overview
This PR refactors the ReactiveUI codebase to replace Locator.Current and Locator.CurrentMutable with AppLocator.Current and AppLocator.CurrentMutable from the Splat dependency injection library. This standardizes dependency resolution throughout the framework. However, the PR also includes several unrelated changes to project files and documentation that should ideally be in separate PRs.
Key Changes
- Consistent replacement of
LocatorwithAppLocatoracross all ReactiveUI core, WPF, Winforms, and MAUI platform implementations - Removal of Windows 10.0.17763.0 platform support from project files (unrelated change)
- Removal of several PackageReference elements for netstandard (unrelated change)
- Documentation updates to DispatcherScheduler.cs (unrelated change)
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ReactiveUI/View/ViewLocator.cs | Updated to use AppLocator.Current for resolving IViewLocator |
| src/ReactiveUI/View/DefaultViewLocator.cs | Updated to use AppLocator.Current for service resolution |
| src/ReactiveUI/Suspension/SuspensionHostExtensions.cs | Updated to use AppLocator.Current for resolving ISuspensionDriver |
| src/ReactiveUI/ReactiveUI.csproj | Removed Windows 10.0.17763.0 support and netstandard PackageReferences (unrelated to main PR purpose) |
| src/ReactiveUI/Mixins/ReactiveNotifyPropertyChangedMixin.cs | Updated to use AppLocator.Current for resolving ICreatesObservableForProperty services |
| src/ReactiveUI/Mixins/DependencyResolverMixins.cs | Updated comments and code references from Locator to AppLocator |
| src/ReactiveUI/Bindings/Property/PropertyBinderImplementation.cs | Updated to use AppLocator.Current for resolving binding converters and hooks |
| src/ReactiveUI/Bindings/Command/CreatesCommandBinding.cs | Updated to use AppLocator.Current for resolving ICreatesCommandBinding services |
| src/ReactiveUI/Bindings/Command/CommandBinder.cs | Updated to use AppLocator.Current for resolving ICommandBinderImplementation |
| src/ReactiveUI/Activation/ViewForMixins.cs | Updated to use AppLocator.Current for resolving IActivationForViewFetcher services |
| src/ReactiveUI.Wpf/Rx/Concurrency/DispatcherScheduler.cs | Changed class documentation format (unrelated to main PR purpose) |
| src/ReactiveUI.Wpf/ReactiveUI.Wpf.csproj | Removed Windows 10.0.17763.0 conditional compilation (unrelated to main PR purpose) |
| src/ReactiveUI.Wpf/Common/ViewModelViewHost.cs | Updated to use AppLocator.Current for resolving IPlatformOperations |
| src/ReactiveUI.Wpf/Common/RoutedViewHost.cs | Updated to use AppLocator.Current for resolving IPlatformOperations |
| src/ReactiveUI.Winforms/ReactiveUI.Winforms.csproj | Removed Windows 10.0.17763.0 conditional compilation (unrelated to main PR purpose) |
| src/ReactiveUI.Maui/RoutedViewHost.cs | Updated to use AppLocator.Current for resolving IScreen |
| src/ReactiveUI.Maui/ReactiveShellContent.cs | Updated to use AppLocator.Current for view resolution and null checks |
| src/ReactiveUI.Maui/Common/ViewModelViewHost.cs | Updated to use AppLocator.Current for resolving IPlatformOperations |
| src/ReactiveUI.Maui/Common/RoutedViewHost.cs | Updated to use AppLocator.Current for resolving IPlatformOperations |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4217 +/- ##
=======================================
Coverage 33.94% 33.94%
=======================================
Files 145 145
Lines 6269 6269
Branches 945 945
=======================================
Hits 2128 2128
Misses 3973 3973
Partials 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update
What is the new behavior?
Updated all usages of Locator.Current and Locator.CurrentMutable to AppLocator.Current and AppLocator.CurrentMutable across the codebase. This change standardizes dependency resolution and improves clarity regarding the application's service locator.
What might this PR break?
Locator usage replaced with underlying AppLocator, not expecting breaking change
Please check if the PR fulfills these requirements
Other information: