Skip to content

Fix race condition in ReactiveCommand cancellation test #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2025
Merged

Fix race condition in ReactiveCommand cancellation test #4196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1939501
Initial plan
Copilot Oct 25, 2025
53985ff
Fix race condition in ReactiveCommandCreateFromTaskThenCancelSetsIsEx…
Copilot Oct 25, 2025
0a2e256
Improve fix for ReactiveCommand test race condition
Copilot Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/ReactiveUI.Tests/Commands/ReactiveCommandTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1811,14 +1811,27 @@ await Task.Delay(
fixture.ThrownExceptions.Subscribe(_ => { });

var latestIsExecutingValue = false;
var subscriptionReady = new TaskCompletionSource<bool>();
var isFirstValue = true;

fixture.IsExecuting.Subscribe(isExec =>
{
statusTrail.Add((position++, $"command executing = {isExec}"));
Volatile.Write(
ref latestIsExecutingValue,
isExec);

// Signal that we've received the first value (should be false initially)
if (isFirstValue)
{
isFirstValue = false;
subscriptionReady.TrySetResult(true);
}
});

// Wait for the subscription to receive the initial value
await subscriptionReady.Task;

var disposable = fixture.Execute().Subscribe();

// Phase 1
Expand Down
Loading