Skip to content

genLoopIndex max length was changed from 50 to 150 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

genLoopIndex max length was changed from 50 to 150 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ exports.genURL = (urlLength) => {
var urlString = "";
const sourceLetters = "ABCDEFGHJKMNPQRSTUVWXYZabcdefghjkmnpqrstuvwxyz23456789";

for(var genLoopIndex = 0; genLoopIndex < 50; genLoopIndex++){
Copy link
Author

@nambihawkins nambihawkins Jan 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error received:

AssertionError: expected 50 to equal 150 + expected - actual -50 +150

for(var genLoopIndex = 0; genLoopIndex < 150; genLoopIndex++){
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error has been fixed by replacing "50" with "150"


// Add a random letter to the urlString
urlString += sourceLetters.charAt(Math.random() * (sourceLetters.length - 1))
Expand Down