Release Day III #92
Merged
Release Day III #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for Max Bot usage once installed. Includes a link in README.md to the usage doc.
Added information about Nodemailer module. Also replaced a reference to `.env` file with `max.config.js` which is current correct env config file.
Create usage documentation
the username can be change but user id will stay the same
…y process it's ok
Custom method now generates verification codes of correct specified length (replaces hard-coded max value)
Create custom exponent method
Email template
MROwens
reviewed
Nov 16, 2017
usage.md
Outdated
|
|
||
| Max also includes a couple of special commands just for Officers and above for making announcements to multiple channels. | ||
|
|
||
| ### !shout |
There was a problem hiding this comment.
Should we remove the !shout and !shoutAll since the functionality will not be in this release?
There was a problem hiding this comment.
Agreed. Let's drop this.
buchholz-sean
suggested changes
Nov 16, 2017
bot/controllers/verify.js
Outdated
| if (guild[el].name === 'crew') { | ||
| m.member.addRole(guild[el].id); | ||
| } else { | ||
| util.log('the moredator has to create the crew role'); |
There was a problem hiding this comment.
Typo: moredator -> moderator; Also, no output and level params passed to util.log(). Recommend util.log(<message>, el, 2);
usage.md
Outdated
|
|
||
| Max also includes a couple of special commands just for Officers and above for making announcements to multiple channels. | ||
|
|
||
| ### !shout |
There was a problem hiding this comment.
Agreed. Let's drop this.
bot/controllers/verify.js
Outdated
| email, | ||
| uuid: uuidv4(), | ||
| verified: 1, | ||
| }).then(util.log).catch(util.error); | ||
| }); | ||
| // maping guild roles to find the crew role id |
There was a problem hiding this comment.
Typo: maping -> mapping
bot/controllers/verify.js
Outdated
| @@ -41,6 +49,7 @@ module.exports = () => { | |||
| if (validDomains.includes(emailDomain)) { | |||
| const codeLength = 6; | |||
| const code = generateCode(codeLength); | |||
| util.log('code', code); | |||
There was a problem hiding this comment.
No debug level param in util.log().
Set collector time to 600000ms (10min) instead of 15000ms (15s) used in testing.
buchholz-sean
approved these changes
Nov 16, 2017
MROwens
approved these changes
Nov 16, 2017
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Day III