Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Paging 3 #14

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Migration to Paging 3 #14

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69bd578
Migration to Paging 3
Aug 17, 2020
7cbc6bc
Remove navigation deps
Aug 18, 2020
93ba4c3
Fix footer issue on pagination
Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove navigation deps
  • Loading branch information
Ashwini Kumar committed Aug 18, 2020
commit 7cbc6bc0025fef864386d62d04cf966e3564b2f3
4 changes: 0 additions & 4 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ plugins {
kotlin("kapt")
kotlin("android.extensions")
id("dagger.hilt.android.plugin")
id("androidx.navigation.safeargs.kotlin")
}

apply {
Expand Down Expand Up @@ -121,8 +120,6 @@ dependencies {
kapt(Deps.AndroidX.Hilt.compiler)
implementation(Deps.AndroidX.multidex)
implementation(Deps.AndroidX.annotation)
implementation(Deps.AndroidX.Navigation.fragmentKtx)
implementation(Deps.AndroidX.Navigation.uiKtx)
// end-region AndroidX

implementation(Deps.OkHttp.main)
Expand Down Expand Up @@ -150,7 +147,6 @@ dependencies {
androidTestImplementation(Deps.AndroidX.Test.Espresso.contrib)
androidTestImplementation(Deps.AndroidX.Test.Espresso.idling_resource)
androidTestImplementation(Deps.AndroidX.Test.rules)
androidTestImplementation(Deps.AndroidX.Navigation.testing)
testImplementation(Deps.truth)
androidTestImplementation(Deps.truth)
testImplementation(Deps.Coroutines.test)
Expand Down
1 change: 0 additions & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ buildscript {
classpath(Deps.android_plugin)
classpath(Deps.Kotlin.gradle_plugin)
classpath(Deps.Hilt.gradlePlugin)
classpath(Deps.AndroidX.Navigation.safeArgs)
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle.kts files
}
Expand Down
9 changes: 0 additions & 9 deletions buildSrc/src/main/kotlin/Dependencies.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ object Deps {
const val material = "1.1.0"
const val android_test_junit = "1.1.1"
const val multidex = "2.0.1"
const val nav_version = "2.3.0"
}

const val android_plugin = "com.android.tools.build:gradle:${Versions.android_plugin}"
Expand All @@ -59,14 +58,6 @@ object Deps {
}

object AndroidX {
object Navigation {
const val fragmentKtx =
"androidx.navigation:navigation-fragment-ktx:${Versions.nav_version}"
const val uiKtx = "androidx.navigation:navigation-ui-ktx:${Versions.nav_version}"
const val testing = "androidx.navigation:navigation-testing:${Versions.nav_version}"
const val safeArgs = "androidx.navigation:navigation-safe-args-gradle-plugin:${Versions.nav_version}"
}

object Test {
const val core = "androidx.test:core:${Versions.android_test}"
const val rules = "androidx.test:rules:${Versions.android_test}"
Expand Down