Skip to content

feat: Normalize into immutablejs state #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: Normalize into immutablejs state #3506

wants to merge 1 commit into from

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jun 12, 2025

Motivation

Solution

Open questions

Copy link

changeset-bot bot commented Jun 12, 2025

⚠️ No Changeset found

Latest commit: 901f45c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 12, 2025

Size Change: +6 B (+0.01%)

Total Size: 77.7 kB

ℹ️ View Unchanged
Filename Size Change
examples/test-bundlesize/dist/App.js 3.42 kB 0 B
examples/test-bundlesize/dist/polyfill.js 311 B 0 B
examples/test-bundlesize/dist/rdcClient.js 10.1 kB +6 B (+0.06%)
examples/test-bundlesize/dist/rdcEndpoint.js 5.61 kB 0 B
examples/test-bundlesize/dist/react.js 57.5 kB 0 B
examples/test-bundlesize/dist/webpack-runtime.js 726 B 0 B

compressed-size-action

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 24e119b Previous: b58f6c4 Ratio
normalizeLong 515 ops/sec (±1.12%) 529 ops/sec (±1.45%) 1.03
denormalizeLong 272 ops/sec (±3.23%) 283 ops/sec (±2.69%) 1.04
denormalizeLong donotcache 987 ops/sec (±1.54%) 1043 ops/sec (±1.10%) 1.06
denormalizeShort donotcache 500x 1578 ops/sec (±0.10%) 1593 ops/sec (±0.20%) 1.01
denormalizeShort 500x 854 ops/sec (±2.01%) 865 ops/sec (±1.79%) 1.01
denormalizeShort 500x withCache 6501 ops/sec (±0.32%) 6709 ops/sec (±0.22%) 1.03
queryShort 500x withCache 2674 ops/sec (±0.29%) 2793 ops/sec (±0.35%) 1.04
buildQueryKey All 52835 ops/sec (±0.50%) 54695 ops/sec (±0.64%) 1.04
query All withCache 6827 ops/sec (±0.36%) 7129 ops/sec (±0.83%) 1.04
denormalizeLong with mixin Entity 277 ops/sec (±2.12%) 282 ops/sec (±2.08%) 1.02
denormalizeLong withCache 7976 ops/sec (±0.56%) 7762 ops/sec (±0.28%) 0.97
denormalizeLong All withCache 6823 ops/sec (±0.42%) 7271 ops/sec (±0.42%) 1.07
denormalizeLong Query-sorted withCache 6841 ops/sec (±0.43%) 7211 ops/sec (±0.99%) 1.05
denormalizeLongAndShort withEntityCacheOnly 1818 ops/sec (±0.31%) 1820 ops/sec (±1.00%) 1.00
getResponse 5570 ops/sec (±1.20%) 5705 ops/sec (±1.34%) 1.02
getResponse (null) 7117589 ops/sec (±0.84%) 7246353 ops/sec (±0.64%) 1.02
getResponse (clear cache) 274 ops/sec (±2.29%) 276 ops/sec (±2.14%) 1.01
getSmallResponse 3071 ops/sec (±0.30%) 3168 ops/sec (±0.20%) 1.03
getSmallInferredResponse 2306 ops/sec (±0.24%) 2295 ops/sec (±0.51%) 1.00
getResponse Collection 5614 ops/sec (±1.04%) 5571 ops/sec (±1.08%) 0.99
get Collection 5565 ops/sec (±0.47%) 5658 ops/sec (±0.29%) 1.02
get Query-sorted 6665 ops/sec (±0.27%) 6627 ops/sec (±0.38%) 0.99
setLong 527 ops/sec (±0.32%) 533 ops/sec (±0.37%) 1.01
setLongWithMerge 243 ops/sec (±1.64%) 248 ops/sec (±0.37%) 1.02
setLongWithSimpleMerge 256 ops/sec (±0.44%) 259 ops/sec (±0.29%) 1.01
setSmallResponse 500x 958 ops/sec (±0.43%) 958 ops/sec (±0.27%) 1

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant